Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make preferred-dir the default read/write directory for slash commands #881

Merged
merged 19 commits into from
Jul 9, 2024
Merged

Make preferred-dir the default read/write directory for slash commands #881

merged 19 commits into from
Jul 9, 2024

Conversation

andrewfulton9
Copy link
Contributor

Closes #880

adds preferred_dir attribute and _output_dir property to BaseChatHandler and updates children handlers to use self._output_dir property in place of self.root_dir.

andrewfulton9 and others added 7 commits July 8, 2024 16:55
@andrewfulton9
add preferred dir functionality to BaseChatHandler
9aa9afe
@andrewfulton9
remove print
c9aa90d
@andrewfulton9
cleanup
2096237
@andrewfulton9
Change /learn to use _output_dir instead of root dir
5a8b865
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
13618c7 
for more information, see https://pre-commit.ci
@andrewfulton9
Merge remote-tracking branch 'upstream/main' into preferred_dir # Ple…
5c3cb93 
…ase enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@andrewfulton9
Merge branch 'preferred_dir' of github.com:andrewfulton9/jupyter-ai i…
2a59a01 
…nto preferred_dir
@srdas srdas added the bug Something isn't working label Jul 8, 2024
@dlqqq
Copy link
Member

dlqqq commented Jul 8, 2024 •
edited
Loading

@andrewfulton9 Thank you for opening this PR! I'm planning to give this a review by tomorrow.

@srdas
Copy link
Collaborator

srdas commented Jul 8, 2024 •
edited
Loading

Tested the branch and it is working as expected:
Start Jupyter Lab : jupyter lab --preferred-dir='/Users/sanjivda/GitHub/TEST/'
Try both /export and /generate:
image
image
Also tested that when there is no preferred-dir, then it is written to the starting directory.

Also tested this with /learn -r arxiv <filename> to make sure the reference TeX file is stored in the preferred directory as well.
image
image

srdas
srdas reviewed Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@srdas srdas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested the new branch. Works as expected.
@andrewfulton9 Thanks for the nice contribution.

dlqqq
dlqqq requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewfulton9 Thank you for implementing this and helping us clean up the backend! Love that we're unifying logic. Left you a minor comment below.

@srdas Thank you for testing & verifying this PR for me.

packages/jupyter-ai/jupyter_ai/chat_handlers/base.py Outdated Show resolved Hide resolved
dlqqq
dlqqq approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewfulton9 Awesome work, thank you!

@dlqqq dlqqq merged commit 0d86ee8 into jupyterlab:main Jul 9, 2024
8 checks passed
@krassowski krassowski mentioned this pull request Jul 11, 2024
Closed
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
@andrewfulton9 @pre-commit-ci
@dlqqq @Marchlak
Make preferred-dir the default read/write directory for slash commands (
4107f57 
jupyterlab#881)

* add preferred dir functionality to BaseChatHandler

* remove print

* cleanup

* Change /learn to use _output_dir instead of root dir

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add preferred dir functionality to BaseChatHandler

* remove print

* cleanup

* Change /learn to use _output_dir instead of root dir

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* change _output_dir to output_dir

* Update packages/jupyter-ai/jupyter_ai/chat_handlers/base.py

Co-authored-by: david qiu <[email protected]>

* add type hint

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: david qiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srdas srdas srdas left review comments

@dlqqq dlqqq dlqqq approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slash commands should read/write to preferred-dir instead of root-dir
3 participants
@andrewfulton9 @dlqqq @srdas